[RFC-0004]: imagerepo: Add support for insecure registries #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan9600
changed the title
aryan9600
force-pushed
the
rfc-insecure-http
branch
2 times, most recently
from
796a8a1
to
5790e64
Compare
aryan9600
force-pushed
the
rfc-insecure-http
branch
from
5790e64
to
18e07e0
Compare
aryan9600
force-pushed
the
rfc-insecure-http
branch
from
18e07e0
to
0c9071d
Compare
Add a new field `.spec.insecure` to the `ImageRepository` API to allow indicating that the registry is an insecure registry, i.e. hosted at an HTTP endpoint. Furthermore, add a new flag `--insecure-allow-http` to allow the controller to make HTTP requests. By default, it is set to true to ensure backwards compatibility. Implements [RFC-0004](https://github.com/fluxcd/flux2/tree/main/rfcs/0004-insecure-http). Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
aryan9600
force-pushed
the
rfc-insecure-http
branch
from
0c9071d
to
801adfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new field
.spec.insecureto theImageRepositoryAPI to allow indicating that the registry is an insecure registry, i.e. hosted at an HTTP endpoint. Furthermore, add a new flag--insecure-allow-httpto allow the controller to make HTTP requests. By default, it is set to true to ensure backwards compatibility.Implements RFC-0004.
Fixes: #324,#325
Part of: fluxcd/flux2#3310