Add extra tags to Grafana annotations #405
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the name and namespace tags to Grafana annotations. This makes it possible to use this provider when one has multiple Flux tenants writing to the same Grafana instance. Signed-off-by: Bill Franklin <b.franklin@mwam.com>
|
I can also add |
There was a problem hiding this comment.
Please document this change in https://github.com/fluxcd/notification-controller/blob/main/docs/spec/v1beta1/provider.md#grafana
|
@bilbof if you need assistance in documenting this change, I'd be happy to help getting this PR merged. Just let me know. |
|
Hey guys, any updates on this PR? I'd like to see this one get merged. Regarding the documentation: This PR is only adding additional tags. The current tags are not documented anywhere |
|
@stefanprodan sorry to ping you, but the PR is not moving forward, though it's an easy fix... How can we help to get this PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the name and namespace tags to Grafana annotations.
This makes it possible to use the Grafana provider when one has multiple Flux tenants writing to the same Grafana instance.