Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add envsubst package #758

Merged
merged 4 commits into from Apr 8, 2024
Merged

Add envsubst package #758

merged 4 commits into from Apr 8, 2024

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Apr 8, 2024

This PR contains a fork of https://github.com/gomodules/envsubst and incorporates drone/envsubst#34.

This permanent fork is needed because envsubst powers a GA feature of Flux, and the Drone's project looks like is no longer maintained.

xref: fluxcd/flux2#4694

@stefanprodan stefanprodan requested a review from a team as a code owner April 8, 2024 06:32
@stefanprodan stefanprodan added the area/envsubst envsubst related issues and pull requests label Apr 8, 2024
@makkes
Copy link
Member

makkes commented Apr 8, 2024

I think we should accompany this PR with an upstream PR to gomodules/envsubst to add the feature of drone/envsubst#34 so that we can remove this fork from our repo once gomodules/envsubst has been released with the feature.

@stefanprodan
Copy link
Member Author

stefanprodan commented Apr 8, 2024

@makkes we can't do that, gomodules/envsubst has diverged from upstream and requires all vars to be specified. Also we may want to add features specific to Flux, for example functions to cope with YAML numbers & booleans.

@makkes
Copy link
Member

makkes commented Apr 8, 2024

@makkes we can't do that, gomodules/envsubst has diverged from upstream and requires all vars to be specified. Also we may want to add features specific to Flux, for example functions to cope with YAML numbers & booleans.

Ah, I understand. So this is meant to be a permanent fork. 👍🏻

Forked from https://github.com/drone/envsubst

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Incorporate drone/envsubst#34

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Copy link
Member

@souleb souleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanprodan stefanprodan merged commit e6464cb into main Apr 8, 2024
12 checks passed
@stefanprodan stefanprodan deleted the envsubst branch April 8, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/envsubst envsubst related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants