Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for Helm GA #1909

Merged
merged 6 commits into from
May 13, 2024
Merged

Update documentation for Helm GA #1909

merged 6 commits into from
May 13, 2024

Conversation

souleb
Copy link
Member

@souleb souleb commented Apr 8, 2024 •
edited

Update documentation for Helm GA

  • move source.toolkit.fluxcd.io/v1beta2 to source.toolkit.fluxcd.io/v1 for HelmChart and HelmRepository
  • move helm.toolkit.fluxcd.io/v2beta2 to helm.toolkit.fluxcd.io/v2 for Helmrelease
  • document the usage of .spec.chartRef
  • update github promotion documentation

https://deploy-preview-1909--fluxcd.netlify.app/flux/guides/helmreleases/

@souleb souleb marked this pull request as draft April 8, 2024 15:09
stefanprodan
stefanprodan reviewed Apr 8, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove HelmRepo type: oci from this guide.

@souleb
Document the new chartRef field in HelmRelease
1f9c18c 
Signed-off-by: Soule BA <bah.soule@gmail.com>
@souleb
remove helmRepository of type oci
2b7eccb 
Signed-off-by: Soule BA <bah.soule@gmail.com>
@souleb souleb marked this pull request as ready for review April 9, 2024 16:00
@souleb souleb marked this pull request as draft April 9, 2024 16:00
@souleb
add a helmChart chartref example
22d16f4 
Signed-off-by: Soule BA <bah.soule@gmail.com>
@souleb souleb marked this pull request as ready for review April 23, 2024 09:07
@souleb @stefanprodan
add a digest based promotion example
55bbca7 
Co-authored-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Soule BA <bah.soule@gmail.com>
@souleb
upgrade apis for helm GA
b3dba1e 
Signed-off-by: Soule BA <bah.soule@gmail.com>
stefanprodan
stefanprodan approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @souleb

@souleb souleb changed the title Document the new chartRef field in HelmRelease Update documentation for Helm GA May 13, 2024
@souleb souleb added area/docs Documentation related issues and pull requests area/api API related issues and pull requests labels May 13, 2024
darkowlzz
darkowlzz reviewed May 13, 2024
View reviewed changes
content/en/flux/guides/helmreleases.md Outdated Show resolved Hide resolved
content/en/flux/guides/helmreleases.md Outdated Show resolved Hide resolved
content/en/flux/guides/helmreleases.md Outdated Show resolved Hide resolved
content/en/flux/guides/helmreleases.md Outdated Show resolved Hide resolved
content/en/flux/guides/helmreleases.md Outdated Show resolved Hide resolved
content/en/flux/use-cases/gh-actions-helm-promotion.md Outdated Show resolved Hide resolved
@souleb
address review comments
9f7d7b3 
Signed-off-by: Soule BA <bah.soule@gmail.com>
@stefanprodan stefanprodan merged commit a7b5ee0 into main May 13, 2024
5 checks passed
@stefanprodan stefanprodan deleted the document-helm-chartref branch May 13, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkowlzz darkowlzz darkowlzz left review comments

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/api API related issues and pull requests area/docs Documentation related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@souleb @darkowlzz @stefanprodan