feat: migrate birthday handler to scheduler job #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdellaert
approved these changes
May 22, 2024
|
Let me know when you plan to merge this and I can set the environment variable in DigitalOcean. Even if I do it a little later (like a few hours), it wouldn't make too much of a difference because once I set it, it would trigger a restart, get the job set up and it would post whatever birthdays it could have missed :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ENV variable must be set before being merged
This PR migrates the birthday handler to be run with the scheduler. The birthday function was written before the scheduler and never migrated.
The interval that birthdays are checked is set in the environment variables.
Code works as before, just with some bug fixes and small improvements.
The gifs will also be stored on our CDN.
Test Results
Discord Username
benw8484