-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add autocomplete support #52
Merged
benw202
merged 17 commits into
flybywiresim:staging
from
ExampleWasTaken:feat-autocomplete
May 23, 2024
Merged
feat: add autocomplete support #52
benw202
merged 17 commits into
flybywiresim:staging
from
ExampleWasTaken:feat-autocomplete
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
benw202
reviewed
May 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add src/lib/autocomplete.ts
to the index.ts file in the lib dir.
You will then need to change your import in slashCommand.ts
Yep good point. Will do. |
benw202
requested changes
May 12, 2024
benw202
reviewed
May 14, 2024
Co-authored-by: BenW <bwilliams12@me.com>
Co-authored-by: BenW <bwilliams12@me.com>
benw202
approved these changes
May 14, 2024
pdellaert
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the autocomplete feature of slash commands.
The implementation closely follows the already existing infrastructure by adding a third (and optional) argument for an autocomplete-callback function to the
slashCommand()
function.Test Results
This PR has no effect on existing code. It only lays the groundwork for future commands that may require autocompletion.
Additional Information
This PR is required for #51.
Discord Username
examplewastaken