Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

javascript-eslint fix config detection in eslint 6 #1594

Closed
wants to merge 1 commit into from
Closed

javascript-eslint fix config detection in eslint 6 #1594

wants to merge 1 commit into from

Conversation

ar1a
Copy link

@ar1a ar1a commented Jul 1, 2019

fixes #1593

@ar1a
Copy link
Author

ar1a commented Jul 1, 2019

oh my god the commit message is misspelled 😭

@cpitclaudel
Copy link
Member

Thanks! That typo looks like the perfect job for a git rebase or git commit --amend :)

@ar1a ar1a changed the title javascrip-eslint: fix config detection in eslint 6 javascript-eslint fix config detection in eslint 6 Jul 1, 2019
@cpitclaudel
Copy link
Member

I think you're missing a closing parenthesis )

@ar1a
Copy link
Author

ar1a commented Jul 1, 2019 via email

@fmdkdd
Copy link
Member

fmdkdd commented Jul 3, 2019

Closing in favor of #1588.

@fmdkdd fmdkdd closed this Jul 3, 2019
@cpitclaudel cpitclaudel mentioned this pull request Jul 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config discovery no longer works in eslint 6
3 participants
@ar1a @cpitclaudel @fmdkdd