Add a new checker 'r' for R #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This is a rather rudimentary checker using only the builtin 'parse' function of R. It can only report syntax/parsing errors, but it does not depend on any third-party libraries. R actually has some builtin utilities for linting (for example, 'codetools'), but as far as I know those require evaluating the source code, so only 'parse' is used.
kunhtkun
force-pushed
the
r-parse-checker
branch
from
2c74b49
to
83e2f1b
Compare
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rather rudimentary checker using the builtin
parsefunction of R. It can only report syntax/parsing errors, but it does not depend on any third-party libraries. So hopefully this checker would still be useful.As for testing, I saw:
flycheck/doc/contributor/contributing.rst
Lines 93 to 95 in 1cc0415
However, it seems that tests for the
r-lintrchecker are still written with ERT inflycheck-test.el, so I again added an ERT test for this checker. Please let me know if this is not good.Thanks!