option to not prevent key events #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,6 +67,7 @@ var Typeahead = React.createClass({ | |||
| placeholder: "", | |||
| textarea: false, | |||
| inputProps: {}, | |||
| preventKeyEvents: true, | |||
There was a problem hiding this comment.
This seems to be named awkwardly. The name suggests that setting it to true will prevent key events. Perhaps this should be renamed to propagateKeyEvents and default to false? Then the code in _onKeyDown would be
if (!this.props.propagateKeyEvents) {
event.preventDefault();
}
|
Otherwise looks good. |
|
How about merge ? |
|
That would be awesome. Nothing against changing the name of the property. |
|
I would really like to be able to use this feature. Any chance of getting it merged? If we are waiting until we can get an update on the naming convention, I could submit an update to the naming convention. |
|
@arahansen I'll pick this up if someone sends me a PR with an updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #110. Created a new prop to enable/disable keyDown default prevention. In my case having it as false works great so when a user tabs the field gets populated with the first visible option and it jumps right to the next field.