Fix: enable FMT_NORETURN
without exception support too
#3917
+5
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building
format.cc
as such with GCC 13.2.1:I get:
Note that, with
FMT_EXCEPTIONS
defined to 0:report_error(const char *)
usesFMT_THROW()
which expands to callingassert_fail()
.assert_fail()
callsstd::terminate()
which has the[[noreturn]]
attribute since C++11.Therefore, with
FMT_EXCEPTIONS
defined to 0, bothassert_fail()
andreport_error()
need to have the[[noreturn]]
attribute too (if available). In other words,FMT_NORETURN
doesn't depend onFMT_EXCEPTIONS
.Also adding
FMT_NORETURN
to twoon_error()
functions which callreport_error(const char *)
.Other
report_error()
overloads eventually return, therefore they don't needFMT_NORETURN
.