Skip to content

Commit

Permalink
Update tabbable to v6.0.0 (#770)
Browse files Browse the repository at this point in the history
  • Loading branch information
stefcameron committed Aug 17, 2022
1 parent 5b64423 commit 47f62ac
Show file tree
Hide file tree
Showing 7 changed files with 68 additions and 36 deletions.
5 changes: 5 additions & 0 deletions .changeset/cyan-baboons-smile.md
@@ -0,0 +1,5 @@
---
'focus-trap': major
---

🚨 **Breaking:** Tabbable dependency has been updated to v6.0.0 and contains a breaking change related to detached nodes with its default `displayCheck` setting. See tabbable's [changelog](https://github.com/focus-trap/tabbable/blob/master/CHANGELOG.md#600) for more information.
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Expand Up @@ -17,7 +17,7 @@ __Please leave this checklist in your PR.__
- Issue being fixed is referenced.
- Unit test coverage added/updated.
- E2E (i.e. demos) test coverage added/updated.
- ⚠️ Non-covered demos (look for `IS_CYPRESS_ENV === ''` [here](https://github.com/focus-trap/focus-trap/blob/master/docs/js/index.js), as well as `in-open-shadow-dom.js` and `negative-tabindex.js` that can't be fully tested in Cypress) __manually__ verified.
- ⚠️ Non-covered demos (look for `// TEST MANUALLY` comments [here](https://github.com/focus-trap/focus-trap/blob/master/docs/js/index.js)) that can't be fully tested in Cypress have been __manually__ verified.
- Typings added/updated.
- Changes do not break SSR:
- Careful to test `typeof document/window !== 'undefined'` before using it in code that gets executed on load.
Expand Down
82 changes: 55 additions & 27 deletions docs/demo-bundle.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/demo-bundle.js.map

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions docs/js/index.js
Expand Up @@ -20,7 +20,7 @@ require('./iframe')();
// it manually
// eslint-disable-next-line no-undef -- process is defined via Rollup
if (!process.env.IS_CYPRESS_ENV) {
require('./in-iframe')();
require('./in-iframe')(); // TEST MANUALLY (causes Cypress to fail due to security context violations)
}

require('./allow-outside-click')();
Expand All @@ -36,5 +36,4 @@ require('./in-open-shadow-dom')();
require('./with-shadow-dom')(); // TEST MANUALLY (Cypress doesn't support Shadow DOM well)
require('./negative-tabindex')();
require('./negative-tabindex-last')();

require('./with-open-web-component')(); // TEST MANUALLY (Cypress doesn't support Shadow DOM well)
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -63,7 +63,7 @@
},
"homepage": "https://github.com/focus-trap/focus-trap#readme",
"dependencies": {
"tabbable": "^5.3.3"
"tabbable": "^6.0.0"
},
"devDependencies": {
"@babel/cli": "^7.18.10",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Expand Up @@ -4913,10 +4913,10 @@ supports-color@^8.1.1:
dependencies:
has-flag "^4.0.0"

tabbable@^5.3.3:
version "5.3.3"
resolved "https://registry.yarnpkg.com/tabbable/-/tabbable-5.3.3.tgz#aac0ff88c73b22d6c3c5a50b1586310006b47fbf"
integrity sha512-QD9qKY3StfbZqWOPLp0++pOrAVb/HbUi5xCc8cUo4XjP19808oaMiDzn0leBY5mCespIBM0CIZePzZjgzR83kA==
tabbable@^6.0.0:
version "6.0.0"
resolved "https://registry.yarnpkg.com/tabbable/-/tabbable-6.0.0.tgz#7f95ea69134e9335979092ba63866fe67b521b01"
integrity sha512-SxhZErfHc3Yozz/HLAl/iPOxuIj8AtUw13NRewVOjFW7vbsqT1f3PuiHrPQbUkRcLNEgAedAv2DnjLtzynJXiw==

term-size@^2.1.0:
version "2.2.0"
Expand Down

0 comments on commit 47f62ac

Please sign in to comment.