UIDEXP-321 Update translations in logs list #385
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -24,6 +24,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/eslint-parser": "^7.18.2", | |||
| "@babel/plugin-transform-class-properties": "^7.22.5", | |||
There was a problem hiding this comment.
These changes belong in a different PR. Also note that instead of maintaining these deps here and syncing them with a custom babel.config.js, a simpler/safe option is to just leverage the config used by stripes-webpack and exported via stripes-cli, e.g. in stripes-core:
const { babelOptions } = require('@folio/stripes-cli');
// ... customizations
module.exports = {
...babelOptions,
};
| "react-virtualized-auto-sizer": "*", | ||
| "regenerator-runtime": "^0.13.3", | ||
| "sinon": "^7.1.1", | ||
| "react-virtualized-auto-sizer": "*" | ||
| "sinon": "^7.1.1" |
There was a problem hiding this comment.
I understand this is just yarn reorganizing deps, but it is never save to depend on a * version. RVAS, in particular, has been the source of some really sneaky problems over the last few months (STCOM-1148). If you notice this kind of thing in the future, please file a ticket to fix it. I filed UIDEXP-325 for this one.
Purpose
https://issues.folio.org/browse/UIDEXP-321
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.