Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIDEXP-323 "View all" logs alignment is flawed #386

Merged
merged 4 commits into from
Jun 23, 2023
Merged

UIDEXP-323 "View all" logs alignment is flawed #386

merged 4 commits into from
Jun 23, 2023

Conversation

vashjs
Copy link
Contributor

@vashjs vashjs commented Jun 22, 2023

Purpose

https://issues.folio.org/browse/UIDEXP-323

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@vashjs vashjs requested review from UladzislauKutarkin and a team June 22, 2023 08:56
@github-actions
Copy link

github-actions bot commented Jun 22, 2023

Jest Unit Test Statistics

205 tests  ±0   205 ✔️ ±0   3m 3s ⏱️ +50s
  33 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit e00e7ab. ± Comparison against base commit cba96d1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 22, 2023

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit e00e7ab. ± Comparison against base commit cba96d1.

♻️ This comment has been updated with latest results.

Copy link

@Terala-Priyanka Terala-Priyanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a screen cast?

package.json Outdated Show resolved Hide resolved
# Conflicts:
#	CHANGELOG.md
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vashjs
Copy link
Contributor Author

vashjs commented Jun 23, 2023

Could you add a screen cast?

Sure, screencast is attached. It's floating issue, and happens only in case if you have some fields with static width and other fields have auto width

Data export - FOLIO

@vashjs vashjs merged commit e3290ff into master Jun 23, 2023
6 checks passed
@vashjs vashjs deleted the UIDEXP-323 branch June 23, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants