New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIDATIMP-690 prevent ESLint from dying #712
Conversation
Due to a [bug in jsx-exlint](jsx-eslint/jsx-ast-utils#103), the changed line causes ESLint to die. The bug [has been fixed](jsx-eslint/jsx-ast-utils#102) but hasn't made it's way into a release yet, and it would be really nice to have lint working again! Refs UIDATIMP-690
yarn run v1.22.4 $ eslint . |
Hello @zburke ! Thank you for this fix, but why didn't this error occur in other PRs and locally? |
@mariia-aloshyna, this error does occur locally for me, and you can see it in other PRs if you look at the console in Jenkins builds from last week and PRs that merged today (search for This is the line from PR #695 that causes ESLint to fail, but it fails in such a polite and quiet way that I think nobody noticed at the time because on GitHub it looks like a comment, rather than an error:
But there are a few things to note:
To be clear, there is nothing technically wrong with this line (the bug is in ESLint, not our own code) but because this line causes ESLint to abort before it finishes its job, that allowed UIDATAIMP-689 to slip through undetected. With this change in place but the one from UIDATAIMP-689 (PR #711) reverted, I now see that import error locally:
Maybe the problem is that Jenkins only listens for |
yarn run v1.22.4 $ eslint . |
Ohhhhh, I see now: when ESLint finds lint errors it exits non-zero and reports those errors on |
yarn run v1.22.4 $ eslint . |
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Due to a bug in jsx-exlint, the changed line causes ESLint to die. The bug has been fixed but hasn't made its way into a release yet, and it would be really nice to have lint working again!
Refs UIDATIMP-690