feat: ✨ added support for esbuild plugins #46
+249
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be great if the PR could be merged - meanwhile using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
I'm using
spawnAsyncto run esbuild, so from the node's require point of view it's a sync call, while under the hood I call esbuild async methodsbuildandtransformwhich enables using esbuild plugins. This is battle tested in my company's huge monorepo, performance is still amazing.I'll release my fork for now to unblock myself (https://www.npmjs.com/package/esbuild-runner-plugins), but I'll gladly work on improving this PR to get this into the mainstream. Looking forward to your feedback!