feat(expect-expect): support chained function names (jest-community#471)

folke · Jan 10, 2020 · f850cbf · f850cbf
1 parent 6f314e1
commit f850cbf
Show file tree

Hide file tree

Showing 3 changed files with 51 additions and 0 deletions.
diff --git a/docs/rules/expect-expect.md b/docs/rules/expect-expect.md
@@ -75,3 +75,23 @@ test('returns sum', () =>
     .run();
 );
 ```
+
+Examples of **correct** code for deep assertion functions with the
+`{ "assertFunctionNames": ["expect", "tester.foo.expect"] }` option:
+
+```js
+/* eslint jest/expect-expect: ["error", { "assertFunctionNames": ["expect", "tester.foo.expect"] }] */
+test('nested expect method call', () => {
+  class Foo {
+    expect(k) {
+      return k;
+    }
+  }
+  let tester = {
+    foo: function() {
+      return new Foo();
+    },
+  };
+  tester.foo().expect(123);
+});
+```
diff --git a/src/rules/__tests__/expect-expect.test.ts b/src/rules/__tests__/expect-expect.test.ts
@@ -26,6 +26,33 @@ ruleTester.run('expect-expect', rule, {
       code: 'it("should return undefined",() => expectSaga(mySaga).returns());',
       options: [{ assertFunctionNames: ['expectSaga'] }],
     },
+    {
+      code: `test('verifies expect method call', () => {
+        class Foo {
+          expect(k) {
+            return k;
+          }
+        }
+        new Foo().expect(123);
+      });`,
+      options: [{ assertFunctionNames: ['Foo.expect'] }],
+    },
+    {
+      code: `test('verifies deep expect method call', () => {
+              class Foo {
+                expect(k) {
+                  return k;
+                }
+              }
+              let tester = {
+                  foo: function() {
+                      return new Foo()
+                  }
+              }
+              tester.foo().expect(123);
+            });`,
+      options: [{ assertFunctionNames: ['tester.foo.expect'] }],
+    },
     {
       code: [
         'test("verifies the function call", () => {',

diff --git a/src/rules/utils.ts b/src/rules/utils.ts
@@ -614,6 +614,10 @@ export function getNodeName(node: TSESTree.Node): string | null {
       break;
     case AST_NODE_TYPES.MemberExpression:
       return joinNames(getNodeName(node.object), getNodeName(node.property));
+    case AST_NODE_TYPES.NewExpression:
+      return getNodeName(node.callee);
+    case AST_NODE_TYPES.CallExpression:
+      return getNodeName(node.callee);
   }
 
   return null;