New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(keys): don't show empty groups" #491

Closed

MariaSolOs wants to merge 1 commit into folke:main from MariaSolOs:empty-groups

Contributor

MariaSolOs commented Jul 29, 2023

Fixes #482.

The original empty-group-problem was brought up by @abeldekat, who later commented on the issue here:

my suggestion would be: Do show empty group names, as the user configures a group name with intent. The group name unexpectedly being empty shows a mismatch between the intent of the user and the actual code...


          Revert "fix(keys): don't show empty groups"

baad1b6

This reverts commit 8503c0d.

Contributor Author

MariaSolOs commented Sep 1, 2023

@folke sorry not sorry for the ping ;)

MariaSolOs closed this by deleting the head repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment