Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare debug as an optional peer dependency #140

Closed
wants to merge 1 commit into from

Conversation

ylemkimon
Copy link
Contributor

Related: #135.

npm (npm/cli#224) and Yarn supports peerDependenciesMeta field in the pakcage.json, which allows to mark a peer dependency as optional.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 50e86f7 on ylemkimon:patch-1 into d320c04 on follow-redirects:master.

@RubenVerborgh
Copy link
Collaborator

Not compatible with #135

@ylemkimon
Copy link
Contributor Author

ylemkimon commented Aug 7, 2020

@RubenVerborgh Actually, it's compatible with #135. peerDependenciesMeta is supported by recent versions of package managers: npm/cli#224, yarnpkg/yarn#6671, and pnpm/pnpm#1486.

AFAIK, it's also possible to set peerDependenciesMeta without declaring peerDependencies. This way, it'll be completely backward compatible and compatible with other package managers. I'll update the PR based on your feedback.

@RubenVerborgh
Copy link
Collaborator

“Recent”, but this library needs to work on old Node versions too. That’s the problem of #135.

@ylemkimon
Copy link
Contributor Author

ylemkimon commented Aug 7, 2020

@RubenVerborgh I've edited PR the branch to include only peerDependenciesMeta. This way it can support all versions. It seems I can't reopen PR. Could you reopen the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants