Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chore): typos found by eslint #2591

Merged
merged 12 commits into from Dec 10, 2022
Merged

fix(chore): typos found by eslint #2591

merged 12 commits into from Dec 10, 2022

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Dec 9, 2022 •
edited

The fixed lines were identified by eslint when developing #2589.

As the changes are fixing bugs (and thus change behaviour) or can potentially have side effects, they are made as a separate PR.

@mvorisek mvorisek marked this pull request as ready for review December 9, 2022 12:42
This was referenced Dec 9, 2022
Draft
Merged
@mvorisek mvorisek changed the title Fix smelly or even wrong code Fix smelly eslint problems Dec 9, 2022
@mvorisek mvorisek changed the title Fix smelly eslint problems Fix smelly typos found by eslint Dec 10, 2022
lubber-de
lubber-de approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de changed the title Fix smelly typos found by eslint fix(chore): typos found by eslint Dec 10, 2022
@lubber-de lubber-de merged commit dbc8d11 into fomantic:develop Dec 10, 2022
@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug type/chore Anything which is a project chore type/ci Anything related to CI/CD javascript Pull requests that update Javascript code labels Dec 10, 2022
@lubber-de lubber-de added this to the 2.9.1 milestone Dec 10, 2022
@mvorisek mvorisek deleted the fix_smelly_code branch December 10, 2022 22:31
mvorisek added a commit to mvorisek/Fomantic-UI that referenced this pull request Dec 10, 2022
@mvorisek
all smelly todos were fixed in fomanticGH-2591
ccfc1e8
@lubber-de lubber-de added the type/lint eslint / stylelint related changes only label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubber-de lubber-de lubber-de approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

@exoego exoego Awaiting requested review from exoego

@y0hami y0hami Awaiting requested review from y0hami

@ko2in ko2in Awaiting requested review from ko2in

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code type/bug Any issue which is a bug or PR which fixes a bug type/chore Anything which is a project chore type/ci Anything related to CI/CD type/lint eslint / stylelint related changes only
Projects
None yet
Milestone
2.9.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvorisek @lubber-de