Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: serialize Pluto.activate_notebook_environment to allow running Pluto notebooks as scripts #2573

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pankgeorg
Copy link
Collaborator

Towards: #2572 (comment)

@github-actions
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="pg/serialize-pkg")
julia> using Pluto

src/runner/PlutoRunner.jl Outdated Show resolved Hide resolved
@pankgeorg pankgeorg marked this pull request as draft May 26, 2023 13:47
@disberd
Copy link
Contributor

disberd commented May 26, 2023

Wouldn't this break packages that use notebooks as included files (unless they explicitly avoid using PlutoPkg).
I didn't try the PR but it would seem from the code that when included outside of Pluto this would create, activate and instantiate the notebook environment instead of the one of the including package

@pankgeorg
Copy link
Collaborator Author

Yes that is a good point. We probably want something more sophisticated here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants