Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Port bash scripts to JS #548

Merged
merged 10 commits into from Oct 5, 2020
Merged

Port bash scripts to JS #548

merged 10 commits into from Oct 5, 2020

Conversation

saschanaz
Copy link
Contributor

Bit longer but better portability.

Closes #546

@saschanaz saschanaz marked this pull request as draft September 26, 2020 18:04
@saschanaz saschanaz marked this pull request as ready for review September 26, 2020 18:13
@foolip
Copy link
Owner

foolip commented Sep 26, 2020

I've opened #549 to run CI on macOS and Windows as well.

@saschanaz
Copy link
Contributor Author

saschanaz commented Sep 26, 2020

Do you want me to rebase this on it?

Copy link
Owner

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Just one paperwork nit :)

scripts.js Show resolved Hide resolved
@foolip
Copy link
Owner

foolip commented Sep 26, 2020

@saschanaz I've landed #549 with the Windows config commented out, so that you can enable it in this PR to show that it's working.

@saschanaz saschanaz marked this pull request as draft September 26, 2020 19:37
@saschanaz
Copy link
Contributor Author

My local unittest result on Windows:

> npm run unittest

.... skipped, just normal successful results ....

  1) "after all" hook in "{root}"

  129 passing (7s)
  1 failing

  1) "after all" hook in "{root}":
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
      at listOnTimeout (internal/timers.js:554:17)
      at processTimers (internal/timers.js:497:7)



[Error: EBUSY: resource busy or locked, unlink 'C:\Users\Kagami\AppData\Local\Temp\puppeteer_dev_firefox_profile-AC0rlQ\cert9.db'] {
  errno: -4082,
  code: 'EBUSY',
  syscall: 'unlink',
  path: 'C:\\Users\\Kagami\\AppData\\Local\\Temp\\puppeteer_dev_firefox_profile-AC0rlQ\\cert9.db'
}

Then it halts forever. 🤔🤔

@saschanaz
Copy link
Contributor Author

I guess it's a puppeteer issue: puppeteer/puppeteer#5673

@saschanaz saschanaz marked this pull request as ready for review October 3, 2020 15:58
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking all good, thanks @saschanaz!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm prepare does not run on Windows
3 participants