FIX (DevOps) @W-15619530@ Fixing more typos in build processes. #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeingold35
commented
May 17, 2024
| @@ -108,7 +108,7 @@ jobs: | |||
| needs: promote-to-latest | |||
| runs-on: macos-latest | |||
| env: | |||
| GH_TOKEN: ${{ github.token }} | |||
| GH_TOKEN: ${{ secrets.SVC_CLI_BOT_GITHUB_TOKEN }} | |||
There was a problem hiding this comment.
Pretty sure we actually wanted to be using the CLI Bot's PAT, so that the workflows about validating PRs will automatically kick off.
| - $ git pull origin dev --no-rebase # You MUST include this flag, or someone's day will be ruined. | ||
| - Resolve the merge conflicts manually. When in doubt, ask the code's author for help. | ||
| - $ git commit | ||
| - $ git checkout dev\n\ |
There was a problem hiding this comment.
I'm not positive that these missing newlines would have broken anything, but their presence definitely can't hurt.
stephen-carter-at-sf
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.