Sanitize organization name #20393
Open
Sanitize organization name #20393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Closes issue 20376 In this pull request, I addressed an issue related to the HTML rendering of organization names in the application. The problem manifested when special characters, such as '&' in the organization name, were not being properly escaped, leading to unintended rendering in the UI. To resolve this issue, I utilized the built-in `sanitize` method provided by Rails. This ensures that organization names are properly sanitized before being rendered in HTML.
laicuRoot
force-pushed
the
laicuroot/sanitize-user-name-20376
branch
from
9ec6bff
to
79af2b3
Compare
laicuRoot
requested review from
lightalloy and
maestromac
and removed request for
a team
|
Prefer to use class OrganizationDecorator def sanitized_name |
maestromac
suggested changes
Mar 28, 2024
There was a problem hiding this comment.
Apologies for the delay. I have to agree with @dambar08 here. The more clean approach here would be to to utilize OrganizationDecorator instead of manually sanitizing names in multiple places. Let me know if you need any more guideline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, I addressed an issue related to the HTML rendering of organization names in the application. The problem manifested when special characters, such as '&' in the organization name, were not properly escaped, leading to unintended rendering in the UI.
To resolve this issue, I utilized the built-in
sanitizemethod provided by Rails. This ensures that organization names are properly sanitized before being rendered in HTML.What type of PR is this? (check all applicable)
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
UI accessibility checklist
If your PR includes UI changes, please utilize this checklist:
CriticalandSeriousissues?For more info, check out the
Forem Accessibility Docs.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?