15549487: Remove _initialize methods from Widget2 #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a good practice to prefer composition over inheritance. And since we don't make widgets inheriting from other widgets anymore, we don't have to separate the initialization of instance variables and the initialization of subwidgets. This is removing _initialize and _initializeSubwidgets in favor of always using the object constructor instead.
JohanBriglia
requested review from
DamienCassou and
BenjaminVanRyseghem
as code owners
DamienCassou
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @BenjaminVanRyseghem)
JohanBriglia
deleted the
15549487/Remove_initialize_methods_from_Widget2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a good practice to prefer composition over inheritance. And since we don't make widgets inheriting from other widgets anymore, we don't have to separate the initialization of instance variables and the initialization of subwidgets.
This is removing _initialize and _initializeSubwidgets in favor of always using the object constructor instead.
👉 Basecamp project/bug
This change is