Skip to content

Commit

Permalink
B7161682765: Remove unused eventCategory.onceOn() method
Browse files Browse the repository at this point in the history
  • Loading branch information
josquindebaz committed Mar 15, 2024
1 parent 3eeca4f commit e252b36
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 47 deletions.
17 changes: 0 additions & 17 deletions src/eventCategory.js
Expand Up @@ -52,23 +52,6 @@ export default function eventCategory() {
return ensureEventHolderFor(name).unregister(binding);
};

/**
* Like on() except callback will only be fired once
*
* @deprecated use registerOnce() instead
* @param name
* @param callback
* @returns {*}
*/
that.onceOn = function (name, callback) {
// eslint-disable-next-line no-console
console.warn(
"Sending onceOn() to a category is deprecated. Send registerOnce() instead.",
);

return that.registerOnce(name, callback);
};

/**
* Like on() except callback will only be fired once
*
Expand Down
30 changes: 0 additions & 30 deletions test/events.test.js
Expand Up @@ -156,33 +156,3 @@ describe("events", () => {
expect(triggered).toBeTruthy();
});
});

describe("deprecated", () => {
/* eslint-disable no-console */
let originalConsoleWarn;

beforeEach(() => {
console.warn = jasmine.createSpy("console.warn");
});

beforeAll(() => {
originalConsoleWarn = console.warn;
});

afterAll(() => {
console.warn = originalConsoleWarn;
});

it("onceOn() category method delegates to registerOnce", () => {
// Arrange: an event
let someEvents = eventCategory();
let spy = jasmine.createSpy("registerOnce");

someEvents.registerOnce = spy;

someEvents.onceOn("namedEvent", "something else");

expect(spy).toHaveBeenCalledWith("namedEvent", "something else");
expect(console.warn).toHaveBeenCalled();
});
});

0 comments on commit e252b36

Please sign in to comment.