Regex problem on window os #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regular expressions truncate characters below '.' char. ex) "nodemon.cmd ==> nodemon" bcz group 2 regex is only '\w+'. So I add regex for get full command. full command need for run on window os. because of child-process use win-bash to window.
|
Please take a look. Let me inform if I need do something. (testing or review) |
|
Could you please add test covering this part of code that would ensure the regex still works correctly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular expressions truncate characters below '.' char.
ex) "nodemon.cmd ==> nodemon"
bcz group 2 regex is only '\w+'. So I add regex for get full command.
full command need for run on window os. because of child-process use win-bash to window.
#140 @romandev