Using java.util.Arrays class when calculating hashcode and equals

forge · Sep 23, 2014 · c793863 · c793863
1 parent 7188660
commit c793863
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/api/src/main/java/org/jboss/forge/roaster/model/util/Refactory.java b/api/src/main/java/org/jboss/forge/roaster/model/util/Refactory.java
@@ -140,7 +140,7 @@ public static void createEquals(final JavaClassSource clazz, final FieldSource<?
          String fieldName = field.getName();
          if (field.getType().isArray())
          {
-            fieldEqualityChecks.append("if (!Arrays.equals(").append(fieldName).append(", other.").append(fieldName)
+            fieldEqualityChecks.append("if (!java.util.Arrays.equals(").append(fieldName).append(", other.").append(fieldName)
                      .append(")) {");
             fieldEqualityChecks.append(" return false; }");
          }
@@ -249,7 +249,7 @@ public static void createHashCode(final JavaClassSource clazz, final FieldSource
          String fieldName = field.getName();
          if (field.getType().isArray())
          {
-            hashCodeComputation.append("result = prime * result + Arrays.hashCode(").append(fieldName).append(");");
+            hashCodeComputation.append("result = prime * result + java.util.Arrays.hashCode(").append(fieldName).append(");");
          }
          else if (field.getType().isPrimitive())
          {

diff --git a/impl/src/test/java/org/jboss/forge/test/roaster/model/util/RefactoryTest.java b/impl/src/test/java/org/jboss/forge/test/roaster/model/util/RefactoryTest.java
@@ -280,16 +280,16 @@ private void assertHashCodeForArrays(MethodSource<JavaClassSource> hashcode)
       assertEquals("hashCode", hashcode.getName());
       assertEquals(0, hashcode.getParameters().size());
       assertEquals("int", hashcode.getReturnType().getName());
-      assertThat(hashcode.getBody(), containsString("result=prime * result + Arrays.hashCode(flags);"));
-      assertThat(hashcode.getBody(), containsString("result=prime * result + Arrays.hashCode(objects);"));
+      assertThat(hashcode.getBody(), containsString("result=prime * result + java.util.Arrays.hashCode(flags);"));
+      assertThat(hashcode.getBody(), containsString("result=prime * result + java.util.Arrays.hashCode(objects);"));
    }
 
    private void assertEqualsForArrays(MethodSource<JavaClassSource> equals)
    {
       assertEquals("equals", equals.getName());
       assertEquals(1, equals.getParameters().size());
-      assertThat(equals.getBody(), containsString("if (!Arrays.equals(flags,other.flags)) {\n  return false;\n}"));
-      assertThat(equals.getBody(), containsString("if (!Arrays.equals(objects,other.objects)) {\n  return false;\n}"));
+      assertThat(equals.getBody(), containsString("if (!java.util.Arrays.equals(flags,other.flags)) {\n  return false;\n}"));
+      assertThat(equals.getBody(), containsString("if (!java.util.Arrays.equals(objects,other.objects)) {\n  return false;\n}"));
    }
 
    @Test