fix(declaration-order): ignore use after the declaration

forivall · Apr 25, 2023 · 2f6e67d · 2f6e67d
1 parent f7e41ce
commit 2f6e67d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/rules/declaration-order.js b/lib/rules/declaration-order.js
@@ -247,7 +247,10 @@ module.exports = {
                             for (const reference of variable.references) {
                                 const idRange = reference.identifier.range;
 
-                                if (idRange[0] >= declaration.range[1]) {
+                                if (
+                                    idRange[0] >= declaration.range[1] &&
+                                    idRange[1] <= node.range[0]
+                                ) {
                                     if (first) {
                                         prevDeclarations.shift();
                                         // eslint-disable-next-line no-labels

diff --git a/tests/lib/rules/declaration-order.js b/tests/lib/rules/declaration-order.js
@@ -141,5 +141,10 @@ new RuleTester().run("declaration-order", rule, {
             parserOptions: { ecmaVersion: 6 },
             errors: letConstErrors,
         },
+        {
+            code: "const c = []; let b; const d = []; c.push(b); const a = [...c]",
+            parserOptions: { ecmaVersion: 6 },
+            errors: [{ ...letConstErrors[0], column: 22 }],
+        },
     ],
 });