Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final nail in the coffin #537

Open
jimmywarting opened this issue Jul 6, 2022 · 1 comment
Open

Final nail in the coffin #537

jimmywarting opened this issue Jul 6, 2022 · 1 comment

Comments

@jimmywarting
Copy link

jimmywarting commented Jul 6, 2022

FormData is shipped natively in all ever green browser and backends now.

Will this be the time for deprecation? form-data haven't been updated in a while and it still lacks some method that should be provided according to the spec. node-fetch@3 stopp recommended ppl using form-data due to inconsistency with spec compatible FormData and recommend that ppl use built in FormData or a spec:ed formdata polyfill that supports iterating over all fields and having Blob/File support. There is at least 3 other spec compatible FormData implementation out there that i know of

  • one provided by undici, the same one that is now also shipped globally in NodeJS v18.
  • fromdata-polyfill used by node-fetch
  • And lastly formdata-node

All of which supports adding 3th party blob/files backed up by a filesystem thanks due to fetch-blob...
formdata-node also has built in fileFromPath()
this is now also being more or less obsolete by the fs.openAsBlob(path)

Perhaps it's time to arcive the repo and put a deprication notice on npm?

@motoyasu-saburi
Copy link

I found a vulnerability in this library and sent a report via Snyk & email,
but received no response.

Therefore, a patch will probably never be provided.
I'm also wondering if I should go public about this issue.

For this reason, I personally feel that it is better to archive it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants