Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve internal dependencies #1342

Merged
merged 10 commits into from
Dec 7, 2022

Conversation

plmercereau
Copy link
Contributor

@plmercereau plmercereau commented Dec 6, 2022

Vanilla

yarn add @nhost/nhost-js graphql

Nextjs

yarn add next react react-dom
yarn add @nhost/nextjs graphql

React

yarn add react react-dom
yarn add @nhost/react graphql

Vue

yarn add vue
yarn add @nhost/vue graphql

React Apollo

yarn add react react-dom
yarn add @nhost/react graphql
yarn add @nhost/react-apollo @apollo/client

Closes #1335

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2022

⚠️ No Changeset found

Latest commit: 8ee2166

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dashboard-staging ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 10:18AM (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 10:18AM (UTC)
example-react-apollo ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 10:18AM (UTC)
example-vue-apollo ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 10:18AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
dashboard ⬜️ Ignored (Inspect) Dec 7, 2022 at 10:18AM (UTC)

Copy link
Contributor

@szilarddoro szilarddoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it ❤️

We should also update the documentation (e.g: https://docs.nhost.io/quickstarts/nextjs#configure-nhost-with-nextjs)

@plmercereau plmercereau changed the title Chore/improve internal dependencies chore: improve internal dependencies Dec 6, 2022
packages/react/package.json Outdated Show resolved Hide resolved
packages/vue/package.json Outdated Show resolved Hide resolved
@plmercereau
Copy link
Contributor Author

The dashboard fails to build. It seems this is somehow related to form-data, that fails to make a browser vs server check and then calls window.
I could not find a way to solve this.
What I tried:

I'm running out of ideas, maybe @szilarddoro could have a look?

@szilarddoro
Copy link
Contributor

The dashboard fails to build. It seems this is somehow related to form-data, that fails to make a browser vs server check and then calls window. I could not find a way to solve this. What I tried:

I'm running out of ideas, maybe @szilarddoro could have a look?

form-data/form-data#537

This issue is a little bit concerning.

@plmercereau plmercereau mentioned this pull request Dec 6, 2022
3 tasks
@plmercereau
Copy link
Contributor Author

The dashboard fails to build. It seems this is somehow related to form-data, that fails to make a browser vs server check and then calls window. I could not find a way to solve this. What I tried:

I'm running out of ideas, maybe @szilarddoro could have a look?

form-data/form-data#537

This issue is a little bit concerning.

Yes it is, and we might need to find a replacement soon. I don't think this is the origin of the problem as before this PR it was working fine. This is somehow related to these changes.
I however tried to replace form-data by formdata-node and ran into the same issue (after I set experimental.esmExternals to loose in the Dashboard Nextjs config

@vercel
Copy link

vercel bot commented Dec 7, 2022

Deployment failed with the following error:

Invalid request: `target` should be string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Nhost Dashboard documentation Improvements or additions to documentation examples nextjs react sdk SDK package vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants