Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add query params to request #298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add query params to request #298

wants to merge 1 commit into from

Conversation

alt-j
Copy link

@alt-j alt-j commented Dec 5, 2016

No description provided.

@coveralls
Copy link

coveralls commented Dec 5, 2016 •
edited

Coverage Status

Coverage remained the same at 97.927% when pulling eaf4cf3 on alt-j:patch-1 into 03444d2 on form-data:master.

@alt-j
Copy link
Author

alt-j commented Dec 6, 2016

I have a case, when I need to send query parameters with files,
and pathname doesn't contain it (https://nodejs.org/docs/latest/api/url.html#url_urlobject_path).

@ettavolt ettavolt mentioned this pull request Jan 7, 2017
Closed
@alexindigo
Copy link
Member

Please see #98. Thank you.

@alexindigo
Copy link
Member

@alt-j Do you mind to add tests? Otherwise, I think we can go ahead with the major version. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alt-j @coveralls @alexindigo