Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require 'new' operator to construct form data. (Browser parity) #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DylanPiercey
Copy link
Member

This is a breaking change (3.x), although most places are probably already using the 'new' operator anyway.

In the browser directly calling FormData throws and this PR mimics that.
Working towards #124.

@coveralls
Copy link

coveralls commented Jul 15, 2017

Coverage Status

Coverage increased (+0.5%) to 98.492% when pulling b8e4aac on DylanPiercey:dom-parity-require-new into 9bfb102 on form-data:master.

Copy link

@jimmywarting jimmywarting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you should remove .DS_Store and package-lock.json

Other then that, looks good

@yordis
Copy link

yordis commented Oct 17, 2018

I believe that if we move to ES6 classes this could be fixed but don't quote me on it.

But we should follow the spec for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants