Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore browser code to improve test coverage #363

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DylanPiercey
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jul 15, 2017

Coverage Status

Coverage remained the same at 97.99% when pulling cda684c on DylanPiercey:browser-coverage into 9bfb102 on form-data:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.99% when pulling cda684c on DylanPiercey:browser-coverage into 9bfb102 on form-data:master.

@alexindigo
Copy link
Member

Do you want to ignore this part of code?
I remember we had issues there before, so it's better to have tests, than just ignore it :)

@DylanPiercey
Copy link
Member Author

IMHO any issues we have with this line of code will be from specific platforms/environments (IE in the past it was service workers I believe). I think that given the extra tooling required to test this (load up a browser, or jsdom) and the fact that even when it's tested issues like that will still go unnoticed, I think we should leave it like this.

I'm not totally against making a test for it, but just think it's more trouble than it's worth. Especially since we are literally only going to change that code if (as mentioned above) a new platform/environment is introduced, specifically one with a weird 'global' context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants