Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note how to defer file descriptor creation/use a stream Ctor #454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Note how to defer file descriptor creation/use a stream Ctor #454

wants to merge 1 commit into from

Commits on Feb 10, 2020

  1. Note how to defer file descriptor creation 

    When appending many files and creating readstreams for each one, you run the real risk of blowing you file descriptor limit.  Generally its better to defer the creation of readStreams until you need to read the file.  

Reading into the combined stream docs, it appeared that this would support the `(next) => next(fs.createReadStream('foo')` api, however its not quite that simple.  This module expects a `path` property on the value so I documented that expectation.  

There is probably room for improvement here, API wise, however this should help assist people from having to read too much code to achieve this outcome. 

Thank you for and open to any suggestions.
    @bcomnes
    bcomnes committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    9abbbdc View commit details
    Browse the repository at this point in the history