Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add @types/node under peerDependencies #511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markandrus
Copy link

This ensures Yarn v2 with Plug'n'Play and TypeScript doesn't complain about form-data missing a dependency on @types/node. See #505. I'm not sure whether or not ^12.0.10 is the correct version to use, but I believe the peerDependencies and devDependencies versions should match.

Tested as follows with Yarn v2:

cd $(mktemp -d)

yarn set version berry

yarn init

yarn add --dev typescript

yarn add form-data@git@github.com:markandrus/form-data.git#head=fix-505 @types/node@^12.0.10

cat >index.ts <<EOF
import FormData = require('form-data')
console.log(FormData)
EOF

yarn run tsc index.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant