change boundary implementation to hex #523
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the boundary doesn't make sense because we are generating a number between 0-9 and converting it to a string with a radix of 16.
If we want the boundary to be base 10, we should have:
boundary += Math.floor(Math.random() * 10).toString(10);
If we want the boundary to be base 16, we should have:
boundary += Math.floor(Math.random() * 16).toString(16);
I'd recommend base 16 because it has more entropy and still conforms with the rfc spec