switch to mime-types module to make form-data browserifyable. #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason this module is not browserifyable is because the mime module does not use
fs.readFileSync
in a compatible way. A pull request to fix this in mime has been open for over a year, but has not merged it (nor given a good reason not to).request itself has switched to using mime-types instead of mime, request/request#943
The mime-types module is drop-in compatible, and I have also updated all tests and they still pass just the same.