Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against overriding window's native FormData accidentally #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anhang
Copy link

@anhang anhang commented Mar 19, 2019

This is to address an issue when using twilio-chat Electron. twilio-chat depends on isomorphic-form-data, which updates global (aka window) in Electron.

@DylanPiercey
Copy link
Member

@alexindigo @anhang I'm not sure this is the best idea here. The node implementation of FormData is not able to be run in a browser as a polyfill. If we are getting to the index.js then that means that we've not properly resolved the browser file, which means the node implementation is being loaded. I think this issue is more of a configuration issue as it seems the electron setup is not resolving the browser field in the package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants