fix(@formatjs/cli): upgrade vue deps

formatjs · Sep 18, 2023 · 166d7ba · 166d7ba
1 parent 6331408
commit 166d7ba
Show file tree

Hide file tree

Showing 8 changed files with 159 additions and 36 deletions.
diff --git a/package.json b/package.json
@@ -67,8 +67,7 @@
     "@typescript-eslint/parser": "^5.0.0",
     "@typescript-eslint/typescript-estree": "^5.9.1",
     "@unicode/unicode-13.0.0": "^1.0.6",
-    "@vue/compiler-core": "^3.2.45",
-    "@vue/compiler-sfc": "^3.2.45",
+    "@vue/compiler-core": "^3.3.4",
     "@vue/test-utils": "2",
     "babel-loader": "9",
     "benchmark": "^2.1.4",
@@ -123,7 +122,7 @@
     "typescript": "5.0.4",
     "unicode-emoji-utils": "^1.1.1",
     "unidiff": "^1.0.2",
-    "vue": "^3.2.45",
+    "vue": "^3.3.4",
     "vue-class-component": "^8.0.0-rc.1",
     "vue-eslint-parser": "^7.3.0",
     "vue-loader": "17",

diff --git a/packages/cli-lib/BUILD b/packages/cli-lib/BUILD
@@ -32,7 +32,7 @@ SRCS = glob(["src/**/*.ts"]) + [
 VUE_DEPS = [
     "//:node_modules/@vue/compiler-core",
     "//:node_modules/@babel/types",
-    "//:node_modules/@vue/compiler-sfc",
+    "//:node_modules/vue",
 ]
 
 SRC_DEPS = [
@@ -84,7 +84,7 @@ esbuild(
     srcs = [":dist-esm-esnext"],
     entry_point = "lib_esnext/main.js",
     external = [
-        "@vue/compiler-sfc",
+        "vue",
     ],
     platform = "node",
     target = "node16",

diff --git a/packages/cli-lib/package.json b/packages/cli-lib/package.json
@@ -47,11 +47,11 @@
     "typescript": "^4.7 || 5"
   },
   "peerDependencies": {
-    "@vue/compiler-core": "^3.2.23",
-    "@vue/compiler-sfc": "^3.2.34"
+    "@vue/compiler-core": "^3.3.4",
+    "vue": "^3.3.4"
   },
   "peerDependenciesMeta": {
-    "@vue/compiler-sfc": {
+    "vue": {
       "optional": true
     },
     "@vue/compiler-core": {

diff --git a/packages/cli-lib/src/vue_extractor.ts b/packages/cli-lib/src/vue_extractor.ts
@@ -1,4 +1,4 @@
-import {parse} from '@vue/compiler-sfc'
+import {parse} from 'vue/compiler-sfc'
 import type {
   TemplateChildNode,
   SimpleExpressionNode,

diff --git a/packages/cli/integration-tests/BUILD b/packages/cli/integration-tests/BUILD
@@ -48,7 +48,7 @@ jest_test(
         "//:node_modules/@babel/types",
         "//:node_modules/@types/node",
         "//:node_modules/@vue/compiler-core",
-        "//:node_modules/@vue/compiler-sfc",
+        "//:node_modules/vue",
         "//:node_modules/fast-glob",
     ],
     flaky = True,

diff --git a/packages/cli/integration-tests/extract-vue/comp.vue b/packages/cli/integration-tests/extract-vue/comp.vue
@@ -7,6 +7,9 @@
       })
     }}
   </p>
+  <div class="message" v-for="message in messages">
+    {{ message.content }}
+  </div>
 </template>
 
 <script>
@@ -17,6 +20,16 @@ intl.formatMessage({
 </script>
 
 <script lang="ts" setup>
+const messages = ref([
+  {
+    id: 1,
+    content: 'Hey, check out this adorable video, bro!!',
+  },
+  {
+    id: 2,
+    content: 'https://youtu.be/dQw4w9WgXcQ',
+  },
+]);
 const intl = useIntl()
 console.log(intl.formatMessage({defaultMessage: 'script setup'}))
 </script>
diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -36,10 +36,10 @@
     "@formatjs/cli-lib": "workspace:*"
   },
   "peerDependencies": {
-    "@vue/compiler-sfc": "^3.2.34"
+    "vue": "^3.3.4"
   },
   "peerDependenciesMeta": {
-    "@vue/compiler-sfc": {
+    "vue": {
       "optional": true
     }
   },