fix(@formatjs/swc-plugin-experimental): visit JSX nested within the call expression #4111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrocat101
force-pushed
the
swcVisitorBugRepro3589
branch
from
3bacf52
to
f8dc579
Compare
unional
pushed a commit
to unional/formatjs
that referenced
this pull request
Jun 7, 2023
…all expression (formatjs#4111) The original Rust implementation does not visit the children of the call expression, as was discovered in formatjs#3589 (comment). This PR fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original Rust implementation does not visit the children of the call expression, as was discovered in #3589 (comment). This PR fixes that.