This repository has been archived by the owner on Jul 10, 2019. It is now read-only.
Days diffs are calculated based on the beginning of the day #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
|
@okuryu pls review & merge, this is critical for business |
|
It is a little more complicated that just this, read tc39/proposal-intl-relative-time#9 for more details. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52
Because day diffs are calculated based on the time between the from and to day, rounded up or down, you could end up saying one day is "yesterday" when it really occurred 12 hours ago on the same day. To fix this we normalize the days to midnight in the current locale and then convert it into milliseconds to calculate the difference in days.
Test included to show that diff between midnight and 1 second before midnight should result in 'yesterday'