(feat): support custom jest config paths via --config #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- --config will now be parsed shallow merged with the defaults,
just like package.json.jest already is
- previously adding --config to tsdx test would result in jest
outputting a usage prompt (I believe due to the second --config
that's added internally) and then the somewhat cryptic
"argv.config.match is not a function"
- if --config is detected, it will be parsed, merged, and then
deleted from argv so that this error doesn't occur anymore
- now that --config is supported, this is fairly straightforward
- rootDir had to be added because TSDX defaults use app root, and not
the directory of the jest.config file
- that matches Jest's default and means no changes have to be made for the internal jest.config.json to work with `tsdx test`
This was referenced Mar 2, 2020
agilgur5
commented
Mar 9, 2020
There was a problem hiding this comment.
Seems ok to me. Would be good if there were a simpler way to remove the config argument or to customize Jest but probably can't do much better as of right now due to Jest's very bare API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--config will now be parsed shallow merged with the defaults,
just like package.json.jest already is
previously adding --config to tsdx test would result in jest
outputting a usage prompt (I believe due to the second --config
that's added internally) and then the somewhat cryptic
"argv.config.match is not a function"
deleted from argv so that this error doesn't occur anymore
Also dogfood
tsdx testinternally (this was the last thing needed for it to be possible) & improve Jest config typingsFixes #150 , or rather what's left of it after #229 .