Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat): support custom jest config paths via --config #526

Merged
merged 4 commits into from
Mar 9, 2020
Merged

(feat): support custom jest config paths via --config #526

merged 4 commits into from
Mar 9, 2020

Commits on Feb 28, 2020

  1. (feat): support custom jest config paths via --config 

    - --config will now be parsed shallow merged with the defaults,
  just like package.json.jest already is

- previously adding --config to tsdx test would result in jest
  outputting a usage prompt (I believe due to the second --config
  that's added internally) and then the somewhat cryptic
  "argv.config.match is not a function"
  - if --config is detected, it will be parsed, merged, and then
    deleted from argv so that this error doesn't occur anymore
    @agilgur5
    agilgur5 committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    e71b33c View commit details
    Browse the repository at this point in the history

  2. (test): dogfood tsdx test for internal testing 

    - now that --config is supported, this is fairly straightforward
  - rootDir had to be added because TSDX defaults use app root, and not
    the directory of the jest.config file
    @agilgur5
    agilgur5 committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    f4b3f41 View commit details
    Browse the repository at this point in the history

  3. (fix): if custom jest config path, use its dir as rootDir 

    - that matches Jest's default and means no changes have to be made for
  the internal jest.config.json to work with `tsdx test`
    @agilgur5
    agilgur5 committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    9c9be2a View commit details
    Browse the repository at this point in the history

  4. (types): improve typings for Jest config

    @agilgur5
    agilgur5 committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    ff5a481 View commit details
    Browse the repository at this point in the history