Skip to content
This repository has been archived by the owner on Apr 30, 2018. It is now read-only.

Added multiSelect input type as extension of select type. #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added multiSelect input type as extension of select type. #48

wants to merge 1 commit into from

Conversation

rowanmoul
Copy link

PR for #47
I added it to select.js rather than make a new file. Let me know if you would like it to have it's own file.

@kentcdodds
Copy link
Member

Thanks for doing this. The problem with this solution is you don't get the same functionality with the multi-select type that you do with the normal select (like custom ngOptions). So I think a better solution would actually be too combine the two together. You can add a property to the ngModelAttrs to have the multi select be added when a property is set to true on the options... I may look into it further unless you want to give it a shot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants