refactor(multiCheckBox): Improve performance #66
Conversation
blowsie
commented
Nov 3, 2015
blowsie
commented
- Improve performance by moving $watch to the exact model
- Improve performance by moving $watch to the exact model
| for (var index = 0; index < newOptionsValues.length; index++) { | ||
| $scope.multiCheckbox.checked[index] = modelValue.indexOf(newOptionsValues[index][valueProp]) !== -1; | ||
| } | ||
| $scope.$watch('to.options', function optionsWatcher(newOptionsValues) { |
There was a problem hiding this comment.
What this will do is essentially create a new watcher every time the model changes. Probably not something we want to do...
There was a problem hiding this comment.
Hmm, I can see this could be an issue, but maybe your missing that this code is already in the repo?
With the way it is pre my changes, this watcher is created every time any section of the form model changes.
There was a problem hiding this comment.
awe dang, you're right! Hmmm... We should probably fix that... I'll create an issue.
|
Sorry, I appreciate what you're trying to do, but I don't think that this will work well. Have you noticed perf issues with this watcher? |
|
Well, I just noticed on large forms that this is being called 100s or 1000s of times and sometimes the multiCheckBox is not even being touched. |
