Support scopes in relationships #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails has relaced the `:conditions` relationships' option with optional lambda/proc `scopes` for a long time already. It just makes sense for Formtastic to support them the same way it does for the `:conditions` option.
Given this code:
```ruby
class Post < ApplicationRecord
belongs_to :author, -> { active.order(name: :asc) }
end
class Author < ApplicationRecord
scope :active, -> { where(active: true) }
end
```
```slim
- semantic_form_for(Post.new) do |f|
= f.input :author
```
Without this change the autogenerated select input with the list of authors will include ALL authors because it effectivelly loads the list from `Author.all`. After this change, the list will be filled with `Author.active.order(name: :asc)` because the `belongs_to` relationship includes a scope.
This seems to bring parity to the old way of applying conditions to relationships via the `:conditions` option which got deprecated back in Rails 4.
|
I'm happy to merge once I figure out why there is no Github Action build for this PR. |
|
Thanks! 🤘 |
|
Thank you! 🥇 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails has replaced the
:conditionsrelationships' option with optional lambda/procscopesfor a long time already. It just makes sense for Formtastic to support them the same way it does for the:conditionsoption.Given this code:
Without this change the autogenerated select input with the list of authors will include ALL authors because it effectively loads the list from
Author.all. After this change, the list will be filled withAuthor.active.order(name: :asc)because thebelongs_torelationship includes a scope.This seems to bring parity to the old way of applying conditions to relationships via the
:conditionsoption which got deprecated back in Rails 4.