-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Github Actions for testing PRs for Docker Builds (Issue #83) #85
Conversation
@Sak1012 Thanks a lot for the PR, I had a look at commit 19975bb and it looks pretty good. Unfortunately we had to run a hard reset on the development branch due to a messed up merge, would you mind cherry picking the relevant changes and opening a PR against the current development branch? If you have trouble doing it or you prefer I can do it myself, I just didn't want to steal the authorship of this PR from you ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please open a new PR against current development
branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we will see in reality how well it fares.
I would probably fix a certain Python version, the one that is required by ticekts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR fails.
Have you tried a local installation before with the same recipe?
With Python 3.12 being automatically selected, it breaks. Same with 3.11 which I tried.
I fear that the very old dependencies, in particular for psycopg2 will make it difficult to automatize it.
We need osycopg2 builds for the version in the requirements for some version of Python we want to use.
I guess the best way forward is:
- update psycopg2 to 2.9.9 which is the latest available version
- test that eventyay-tickets works with that
- bump the requirements version
and after all that is done, we can have github actions tests.
a8f4abe
to
965baae
Compare
.github/workflows/docker-pr.yml
Outdated
- name: Set up Python | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: "3.x" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use 3.8 here as we do with all other versions and tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I am merging this to test. |
This pull request introduces a new GitHub Actions workflow (docker-pr.yml) to automate the building of Docker images for the eventyay-tickets project. The workflow is triggered whenever a pull request is opened or updated targeting the development or main branches. Additionally, it checks and installs Python dependencies before building the Docker image.
Changes Made
ScreenShots
Test Getting triggered on a pull-request made to the development branch of my local repository.
Success message of the test while trying to create a PR in-between to local branches aimed at development branch