#2342 : Multimeter incomplete problem resolve and removed Hardcoded value #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudyPadmal
requested changes
Mar 23, 2024
Aayush1357
changed the title
CloudyPadmal
requested changes
Mar 28, 2024
Comment on lines
189
to
190
| android:layout_marginStart="5dp" | ||
| android:layout_marginTop="5dp" |
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="center" | ||
| android:layout_marginTop="4dp" |
4 tasks
|
Resolved by #2407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2342 Multimeter screen layout incomplete
Changes
app/src/main/res/layout-hdpi/activity_multimeter.xml
app/src/main/res/layout-sw600dp/activity_multimeter.xml
app/src/main/res/layout-xhdpi/activity_multimeter.xml
app/src/main/res/layout/activity_multimeter.xml
app/src/main/res/values/dimens.xml
app/src/main/res/values/strings.xml
Screenshots / Recordings
https://github.com/fossasia/pslab-android/assets/111655141/83612119-a664-4c48-abe1-60124730ccdf
Checklist
strings.xml,dimens.xmlandcolors.xmlwithout hard coding any value.