Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: frequency measurements #126

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: frequency measurements #126

wants to merge 1 commit into from

Conversation

CloudyPadmal
Copy link
Collaborator

@CloudyPadmal CloudyPadmal commented Nov 21, 2021 •
edited

@CloudyPadmal CloudyPadmal added draft firmware-porting Replacing older firmware with newer MCC based firmware labels Nov 21, 2021
@CloudyPadmal CloudyPadmal self-assigned this Nov 21, 2021
@CloudyPadmal CloudyPadmal mentioned this pull request Nov 21, 2021
Open
20 tasks
@CloudyPadmal CloudyPadmal marked this pull request as ready for review June 11, 2022 11:49
bessman
bessman requested changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@bessman bessman left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested that these functions work? I recall that in the legacy firmware several of these were severely buggy. Because of that, pslab-python actually doesn't even use most of these, instead using software implementations based on the logic analyzer.

pslab-core.X/registers/timers/tmr5.h Outdated Show resolved Hide resolved
pslab-core.X/registers/comparators/ic_params.c Outdated Show resolved Hide resolved
pslab-core.X/helpers/interval.c Outdated Show resolved Hide resolved
pslab-core.X/helpers/interval.h Outdated Show resolved Hide resolved
pslab-core.X/instruments/logicanalyzer.c Outdated Show resolved Hide resolved
pslab-core.X/registers/comparators/ic_params.h Outdated Show resolved Hide resolved
pslab-core.X/registers/timers/tmr2.h Outdated Show resolved Hide resolved
pslab-core.X/registers/timers/tmr3.c Outdated Show resolved Hide resolved
pslab-core.X/registers/timers/tmr3.h Outdated Show resolved Hide resolved
pslab-core.X/registers/comparators/ic1.c Outdated Show resolved Hide resolved
This was referenced Sep 18, 2022
Closed
Open
Merged
@CloudyPadmal CloudyPadmal marked this pull request as draft September 24, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bessman bessman bessman requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@CloudyPadmal CloudyPadmal

Labels
firmware-porting Replacing older firmware with newer MCC based firmware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CloudyPadmal @bessman