Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15 Navbar and typography responsiveness #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elit-altum
Copy link
Member

@elit-altum elit-altum commented Feb 4, 2020

  • Included a Preview link and screenshot showing after and before the changes.
  • Included a description of the change below.
  • Squashed the commits.

Changes done in this Pull Request

Description / Changes

  • The Navbar contents flowed out of their specified div between screen size 990px to 768px. To address it, the media queries were changed so that the navbar collapes after 990px only and prevents the spilling
  • The text 'OPENTEXTSUMMIT SINGAPORE' overlapped too close on smaller/mobile screens. The line-height property was added to its CSS to address this issue. In addition, the font-size and letter-spacing for smaller screens was also changed to allow the text to be in proportion and alignment with other text elements on the screen.

Screenshots if any:

Before:

Navbar Overflow:
NavbarOverlayProblem

Typography Overlap:
typographyproblem

After:

Corrected Navbar collapse:
NavbarOverlayFixed

Corrected Typography Overlap:
typographycorrection


@Chaitanyassr
Copy link
Member

Preview link not working, please check ones.

@elit-altum
Copy link
Member Author

elit-altum commented Feb 5, 2020

@Chaitanyassr Should I create one on HerokuApp ? I have followed the repository syntax only.

Copy link
Member

@shivaylamba shivaylamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview Link is not working. You can simply clone the repo, make the changes and deploy the github pages for the test link, since this is a static website, you don't need Heroku. Alternatively you could also use Heroku.

@snitin315
Copy link
Member

@elit-altum just enable github pages under your forked repo settings.

@elit-altum
Copy link
Member Author

Preview link not working, please check ones.

@snitin315 Thank you for your help. The preview link is now working. Please review this PR.
@Chaitanyassr @snitin315

@elit-altum elit-altum removed the request for review from mariobehling February 25, 2020 19:17
@elit-altum
Copy link
Member Author

Could someone please merge this?
@snitin315 ?

@snitin315
Copy link
Member

@elit-altum I don't have the merge rights , I can only help with reviewing code.

@mariobehling please take a look over this PR.

@elit-altum
Copy link
Member Author

@mariobehling Could you please have a look at this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

navbar responsiveness and typography issue
5 participants